Repository navigation
Conversation
Drop ipc_client_mutex before calling auxiliary_device_delete() and auxiliary_device_uninit() in sof_client_dev_unregister(), matching sof_client_dev_register() and avoiding holding the list lock across client driver remove() callbacks. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add snd_sof_ipc4_load_library_from_buf() and expose sof_client_ipc4_load_library_buf() for loading rimage/LLEXT libraries from a host memory buffer, along with debug window slot definitions for the Zephyr winstream shell and LLEXT load rendezvous. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add an auxiliary SOF client driver creating /dev/sof-dspN and its UAPI header include/uapi/sound/sof/cdev.h, exposing: - Device, firmware, and SRAM window/slot discovery (SOF_IOC_GET_INFO) - Power and per-core state control (SOF_IOC_PM_CTL) - Atomic IPC3/IPC4 transactions and large configs - SRAM window/debug-slot read/write and mmap - Zephyr winstream shell/GDB I/O (SOF_IOC_WINSTREAM_IO) - LLEXT library loading (SOF_IOC_LLEXT_LOAD) - SOF probe point control (SOF_IOC_PROBE_CTL) - Async firmware state and IPC notification events via poll()/read() Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the SOF auxiliary client character device driver (
/dev/sof-dspN) and UAPI header (include/uapi/sound/sof/cdev.h) to expose DSP firmware debug, telemetry, IPC, memory window, LLEXT loading, Zephyr winstream shell/GDB, and probe interfaces to userspace tools (such assof-remote-server/sof-top).Summary of commits
sdev->ipc_client_mutexbefore callingauxiliary_device_delete()/auxiliary_device_uninit()insof_client_dev_unregister().snd_sof_ipc4_load_library_from_buf()and exportssof_client_ipc4_load_library_buf()for loading rimage/LLEXT libraries from memory buffers, plusSOF_IPC4_DEBUG_SLOT_SHELLandSOF_IPC4_DEBUG_SLOT_LLEXT_LOADdefinitions.include/uapi/sound/sof/cdev.handsound/soc/sof/sof-client-cdev.c(CONFIG_SND_SOC_SOF_CLIENT_CDEV) supporting:SOF_IOC_GET_INFO: Device, firmware version, core mask, SRAM windows, and Window 2 debug slot descriptorsSOF_IOC_PM_CTL: Query state, wake & hold D0 (holding_d0), release hold, boot DSP, and core get/putSOF_IOC_IPC_TX/SOF_IOC_IPC_LARGE_CFG: Atomic IPC3/IPC4 transactions and module large configsSOF_IOC_WIN_INFO/SOF_IOC_WIN_READ/SOF_IOC_WIN_WRITE+mmap(): Direct SRAM window and debug-slot accessSOF_IOC_WINSTREAM_IO: Zephyr winstream ring-buffer I/O (SOF_CDEV_SLOT_SHELL,SOF_CDEV_SLOT_GDB_STUB)SOF_IOC_LLEXT_LOAD: Shell shm handshake and direct IPC4 library loadingSOF_IOC_PROBE_CTL: Probe init/deinit, active/available query, and point add/removepoll()/read(): AsyncSOF_CDEV_EVT_FW_STATEandSOF_CDEV_EVT_IPC_NOTIFICATIONevent queueVerification (on
sof/topic/sof-dev)sound/soc/sof/sof-client-cdev.o,sound/soc/sof/sof-client.o, andsound/soc/sof/ipc4-loader.owithW=1cleanly.make headers_install+gcc -Wall -Wextra -Werroron<sound/sof/cdev.h>.scripts/checkpatch.pl(0 errors oncdev.handsof-client-cdev.c; fixedKconfigrecursive dependency andkzalloc_objstyle warnings while extracting from the local working tree).